Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElastiCache: Add the create_cache_cluster, delete_cache_cluster and describe_cache_clusters methods support #6754

Merged
merged 34 commits into from
Sep 2, 2023

Conversation

jfmainville
Copy link
Contributor

@jfmainville jfmainville commented Sep 1, 2023

Added the base configuration for the following Elasticache methods:

  1. create_cache_cluster
  2. delete_cache_cluster
  3. describe_cache_clusters

The pagination functionality for the describe_cache_clusters needs to be implemented, but the base configuration that I completed so far can be used to validate the necessary integrations.

…remove and cache_node_ids_to_reboot attributes
@jfmainville jfmainville changed the title ElastiCache: Add the create_cache_cluster, describe_cache_clusters and delete_cache_cluster methods support ElastiCache: Add the create_cache_cluster, delete_cache_cluster and describe_cache_clusters methods support Sep 1, 2023
@jfmainville jfmainville marked this pull request as ready for review September 1, 2023 18:08
@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #6754 (38bc401) into master (866c28a) will decrease coverage by 0.01%.
Report is 20 commits behind head on master.
The diff coverage is 99.29%.

@@            Coverage Diff             @@
##           master    #6754      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         806      812       +6     
  Lines       79359    79644     +285     
==========================================
+ Hits        76351    76619     +268     
- Misses       3008     3025      +17     
Flag Coverage Δ
servertests 37.02% <47.51%> (+0.15%) ⬆️
unittests 96.14% <99.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
moto/elasticache/models.py 99.16% <98.71%> (-0.84%) ⬇️
moto/__init__.py 98.73% <100.00%> (+0.01%) ⬆️
moto/elasticache/exceptions.py 100.00% <100.00%> (ø)
moto/elasticache/responses.py 100.00% <100.00%> (ø)

... and 45 files with indirect coverage changes

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding these features @jfmainville!

@bblommers bblommers added this to the 4.2.1 milestone Sep 2, 2023
@bblommers bblommers merged commit d78db35 into getmoto:master Sep 2, 2023
81 of 82 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This is now part of moto >= 4.2.1.dev37

@jfmainville
Copy link
Contributor Author

LGTM. Thank you for adding these features @jfmainville!

Thanks for the update! I'm working on a project for multiple AWS services at the time, so I will add additional methods over the coming weeks as I'm implementing them.

toshyak pushed a commit to toshyak/moto that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants