Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda: event invoke config #7078

Merged
merged 15 commits into from
Dec 1, 2023

Conversation

rafcio19
Copy link
Contributor

@rafcio19 rafcio19 commented Nov 29, 2023

Resolves #6931

GetFunctionEventInvokeConfig ✅
ListFunctionEventInvokeConfigs ✅
PutFunctionEventInvokeConfig ✅
UpdateFunctionEventInvokeConfig ✅
DeleteFunctionEventInvokeConfig ✅

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e1ea0b) 95.85% compared to head (7b306cd) 95.88%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7078      +/-   ##
==========================================
+ Coverage   95.85%   95.88%   +0.02%     
==========================================
  Files         834      834              
  Lines       81760    82100     +340     
==========================================
+ Hits        78375    78719     +344     
+ Misses       3385     3381       -4     
Flag Coverage Δ
servertests 35.81% <15.85%> (+0.17%) ⬆️
unittests 95.82% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafcio19 rafcio19 force-pushed the feat/lambda_invoke_config branch from 601441f to a99c327 Compare December 1, 2023 07:47
@rafcio19 rafcio19 marked this pull request as ready for review December 1, 2023 22:40
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding this feature @rafcio19!

@bblommers bblommers added this to the 4.2.11 milestone Dec 1, 2023
@bblommers bblommers merged commit 10f8258 into getmoto:master Dec 1, 2023
32 checks passed
@rafcio19 rafcio19 deleted the feat/lambda_invoke_config branch December 2, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting FunctionEventInvokeConfig in Lambda service
2 participants