-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BackendDict instantiation service names #7723
Fix BackendDict instantiation service names #7723
Conversation
Hi @viren-nadkarni!
Do you know from which version of boto3 this changed? If this only happened in a recent version, then people that are stuck on an older version of What is the effect (on LS) of changing these names? |
@bblommers This has been out in Boto for quite a while. We made this change in LocalStack in July 2023, see localstack#68 Also related #6446 |
For the new
Edit: for Edit 2: LocalStack uses this value in the state restoration mechanism to identify the service to which a given backend belongs to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that should be fine then. Thank you @viren-nadkarni!
This is now part of moto >= 5.0.9.dev4 |
This PR updates certain BackendDict initialisations so that they use proper Botocore service name.
Earlier, these services used
ec2
orlambda
sinceboto3.Session().get_available_regions(...)
used to return an empty list.There are still a few instantiations remaining that were not updated for the above reason, these are:
redshiftdata
should useredshift-data
apigatewaymanagementapi
should useapigatewaymanagementapi
bedrockagent
ec2instanceconnect
should useec2-instance-connect