Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom id tag support #8230

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Oct 14, 2024

Motivation

As a follow up to #8216, This pr aims at expanding support of custom ids to resources that can be created with tags. Providing a tag named _custom_ids at creation can be used to create a custom id for the created resource.

Changes

  • Fixed get_id_from_tags method to by able to accept tags created as dict (e.g {"_custom_id_": "myCustomId"}) or as a list (e.g. [ {"Key": "_custom_id_", "Value": "myCustomId"} ])
  • Added tests for apigw and secrets manager to showcase an example of each type

TODO

@cloutierMat cloutierMat mentioned this pull request Oct 15, 2024
@cloutierMat cloutierMat force-pushed the custom-id-tag-support branch from 10dc090 to 57a057b Compare October 15, 2024 03:05
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (d0affa8) to head (57c12b8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8230   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files        1158     1158           
  Lines      100093   100096    +3     
=======================================
+ Hits        94633    94636    +3     
  Misses       5460     5460           
Flag Coverage Δ
servertests 28.88% <66.66%> (+<0.01%) ⬆️
unittests 94.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bblommers bblommers added this to the 5.0.18 milestone Oct 16, 2024
@bblommers bblommers merged commit 6d51cae into getmoto:master Oct 16, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants