Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFormation models for some IoT objects #8277

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

jsuchenia
Copy link
Contributor

I'd like to contribute CloudFormation models for AWS IoT Core service.
Initial models for:

  • AWS::IoT::Thing
  • AWS::IoT::ThingType
  • AWS::IoT::Policy

@jsuchenia jsuchenia force-pushed the feat/iot-cloudformation-models branch from 446f551 to c10a308 Compare November 2, 2024 11:37
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 91.53846% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (5f4c48b) to head (c10a308).

Files with missing lines Patch % Lines
moto/iot/models.py 91.47% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8277      +/-   ##
==========================================
- Coverage   94.56%   94.55%   -0.01%     
==========================================
  Files        1158     1158              
  Lines      100606   100732     +126     
==========================================
+ Hits        95134    95249     +115     
- Misses       5472     5483      +11     
Flag Coverage Δ
servertests 28.87% <37.69%> (+<0.01%) ⬆️
unittests 94.52% <91.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding support for these models @jsuchenia!

@bblommers bblommers added this to the 5.0.18 milestone Nov 2, 2024
@bblommers bblommers merged commit 992713e into getmoto:master Nov 2, 2024
@jsuchenia jsuchenia deleted the feat/iot-cloudformation-models branch November 2, 2024 14:06
@bblommers bblommers modified the milestones: 5.0.18, 5.0.19 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants