Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: add SecurityGroupArn to security groups #8393

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

pinzon
Copy link
Contributor

@pinzon pinzon commented Dec 12, 2024

Motiviation

As stated in the docs the methods for creating and describing a Security Group resource should include the attribute SecurityGroupArn.

Changes

  • ARN generation in the SecurityGroup model
  • Addition of the attribute in the response templates.

Testing

  • Extension of an existing test to assert the presence of the attribute

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.59%. Comparing base (57d0c0e) to head (cc825a7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8393   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files        1159     1159           
  Lines      101447   101448    +1     
=======================================
+ Hits        95964    95965    +1     
  Misses       5483     5483           
Flag Coverage Δ
servertests 28.86% <100.00%> (+<0.01%) ⬆️
unittests 94.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers changed the title add SecurityGroupArn to security groups EC2: add SecurityGroupArn to security groups Dec 13, 2024
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @pinzon!

@bblommers bblommers added this to the 5.0.23 milestone Dec 13, 2024
@bblommers bblommers merged commit b5c665e into getmoto:master Dec 13, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants