s3 put object with object lock header check #8672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #8662 |
bpandola
requested changes
Mar 11, 2025
There was a problem hiding this comment.
@Frank-Schmutz Thanks for this. Can you provide a test case that uses the x-amz-sdk-checksum-algorithm header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of moto requires the
Content-Md5header to be provided when uploading an object with a retention configured using object lock.However the AWS documentation specifies that the
x-amz-sdk-checksum-algorithmheader may be provided instead (AWS doc reference). I can confirm that the documentation is accurate after having performed a couple tests including the latter header instead of the content md5 one.This issue is relevant since botocore does not compute and include the content md5 automatically since version 1.36.0, see changelog.