Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoscaling): Ensure launch template is passed when creating instances in autoscaling groups. #8674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kimamisa
Copy link
Contributor

Ensure launch template is passed when creating instances in autoscaling groups.
This allows listing all disks which are created when an instance is created.

@Kimamisa Kimamisa force-pushed the fix_asg_instance_creation_with_launch_template branch from abd0c0d to 7eb19c0 Compare March 12, 2025 12:07
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (c6f64e8) to head (7eb19c0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8674   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files        1252     1252           
  Lines      108682   108683    +1     
=======================================
+ Hits       100813   100814    +1     
  Misses       7869     7869           
Flag Coverage Δ
servertests 28.27% <0.00%> (-0.01%) ⬇️
unittests 92.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ances in autoscaling groups.

This allows listing all disks which are created when an instance is
created.
@Kimamisa Kimamisa force-pushed the fix_asg_instance_creation_with_launch_template branch from 7eb19c0 to 26ac4e8 Compare March 12, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant