Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start GitHub Actions #3477

Merged
merged 13 commits into from
Nov 21, 2020
Merged

Start GitHub Actions #3477

merged 13 commits into from
Nov 21, 2020

Conversation

felixfontein
Copy link
Contributor

Actions won't be run if this isn't in master.

Since this isn't running anything yet, it should work fine and not start failing right away.

Actions won't be run if this isn't in master.
Since this isn't running anything yet, it should work fine and not start failing right away.
@felixfontein
Copy link
Contributor Author

Interestingly, they actually seem to run in this PR. I guess I can just continue without this being merged :)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
- 3.5
- 3.6
- 3.7
- 3.8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add 3.9.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@Kwpolska Kwpolska mentioned this pull request Nov 15, 2020
3 tasks
@Kwpolska Kwpolska requested a review from ralsina November 15, 2020 12:38
@Kwpolska
Copy link
Member

This now works with macOS and Windows.

@felixfontein, please review the last 3 commits I made.

@ralsina, could you review this? Thanks.

Copy link
Contributor Author

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve since I create this PR, but all new changes look good :)

.github/workflows/ci.yml Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@Kwpolska Kwpolska merged commit 04e6fd8 into master Nov 21, 2020
@Kwpolska Kwpolska deleted the start-gha branch November 21, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants