Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a github_widget shortcode #439

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

dacog
Copy link
Contributor

@dacog dacog commented Jun 23, 2024

Hi,

I created a shortcode to show information for a GitHub repository and I thought it would be interesting for others as well, so here it is.

Please let me know if I have to change anything.

Best regards,

Diego

@Kwpolska
Copy link
Member

This looks great, just one thing missing (from the README):

Please make sure your plugin has a valid open-source license, and that it has a license comment. For short licenses (MIT/BSD), include the entire license text; for longer licenses (Apache, GPL/LGPL), use the short declarations (Apache, GPL). If you don’t know which license to use, we recommend MIT (as seen in Nikola core).

Please also fix the linting errors:

v8/github_widget/github_widget.py:2:1: F401 'nikola.utils.LOGGER' imported but unused
v8/github_widget/github_widget.py:64:9: F841 local variable 'latest_release' is assigned to but never used
v8/github_widget/github_widget.py:65:9: F841 local variable 'latest_commit' is assigned to but never used

@dacog
Copy link
Contributor Author

dacog commented Jun 23, 2024

Hi @Kwpolska

Thank you for your feedback. I thought I had read everything. I just added the License (MIT).

I also updated a part of the code to re-enable the last commit and last release args in the shortcode. It seems I had forgotten to push that part before.

The linting should also be fixed.

Would there still be anything missing?

Thanks!

Diego

@Kwpolska Kwpolska merged commit 9637510 into getnikola:master Jun 23, 2024
7 checks passed
@Kwpolska
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants