Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Datasets.createOrMerge and Datasets.publishIfExists #793

Closed
ktuite opened this issue Mar 20, 2023 · 0 comments · Fixed by #810
Closed

Refactor Datasets.createOrMerge and Datasets.publishIfExists #793

ktuite opened this issue Mar 20, 2023 · 0 comments · Fixed by #810
Assignees
@ktuite
Labels
entities Multiple Encounter workflows refactor

Comments

@ktuite
Copy link
Member

ktuite commented Mar 20, 2023 •
edited
Loading

This is used by Forms.createNew and Forms.createVersion and intersects with Datasets.publishIfExists (called by Forms.publish`).

It creates these audit events: dataset.create, dataset.update, and/or dataset.update.publish.

Changes:

  1. Make inputs cleaner. Move work from Forms query module (to prepare Dataset object, filter form fields) into this function.
  2. Make it async/await!

There was more to this issue but it has been moved to a separate issue that can come later: #811
@ktuite ktuite added refactor entities Multiple Encounter workflows labels Mar 20, 2023
This was referenced Mar 20, 2023
Open
Merged
@ktuite ktuite self-assigned this Mar 24, 2023
@ktuite ktuite mentioned this issue Mar 28, 2023
Merged
2 tasks
@ktuite ktuite linked a pull request Mar 28, 2023 that will close this issue
Move prep work from Forms to Datasets.createOrMerge #810
Merged
2 tasks
sadiqkhoja added a commit to sadiqkhoja/central-backend that referenced this issue May 17, 2023
@sadiqkhoja
enhace getodk#793: query param to sanitize property names
b3beecf
@sadiqkhoja sadiqkhoja mentioned this issue May 17, 2023
Merged
2 tasks
sadiqkhoja added a commit that referenced this issue May 17, 2023
@sadiqkhoja
enhace #793: return odata sanitize property name as well in Dataset M…
8b7d8d0 
…etadata (#873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktuite ktuite

Labels
entities Multiple Encounter workflows refactor
Projects
ODK Central
Status: ✅ done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move prep work from Forms to Datasets.createOrMerge getodk/central-backend
1 participant
@ktuite