Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#573
Uses POSTing to existing
/v1/projects/1/datasets/people/entities
endpoint so it can handle{uuid, label, data}
{entities: [{}, {}], source: {name, size}}
For the source object,
source
is requiredname
within source is required (not sure if it should be but it will help with displaying on the front end...)size
(meant to represent file size)I was thinking about how to handle the bulk SQL insert and decided it was easiest to think/build two separate queries, one for the
entities
table and another for theentity_defs
table. Elsewhere the code, we have complex queries for inserting a single entity's data into both tables at once, but it didn't seem reasonable to try to do that with multiple entities.What has been done to verify that this works as intended?
Tests, trying it out.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
Documentation is included in this PR!!
Before submitting this PR, please make sure you have:
make test-full
and confirmed all checks still pass OR confirm CircleCI build passes