test: handle errors in zipStreamToFiles() #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Jul 29, 2022
| @@ -12,7 +12,9 @@ describe('.zip attachments streaming', () => { | |||
| { row: { instanceId: 'subone', name: 'secondfile.ext', content: 'this is my second file' } }, | |||
| { row: { instanceId: 'subtwo', name: 'thirdfile.ext', content: 'this is my third file' } } | |||
| ]); | |||
| zipStreamToFiles(zipStreamFromParts(streamAttachments(inStream)), (result) => { | |||
| zipStreamToFiles(zipStreamFromParts(streamAttachments(inStream)), (err, result) => { | |||
| if(err) return done(err); | |||
There was a problem hiding this comment.
We don't lint test files at the moment, but I think the linter requires a space between if and (. I don't think that should block merging, but maybe that's all the more reason to try to get #545 merged soon.
| zipfile.close(); | ||
| } else { | ||
| entries.forEach((entry) => { | ||
| result.filenames.push(entry.fileName); | ||
| zipfile.openReadStream(entry, (_, resultStream) => { | ||
| resultStream.pipe(streamTest.toText((_, contents) => { | ||
| zipfile.openReadStream(entry, (err, resultStream) => { |
There was a problem hiding this comment.
Just another small linting thing, I think the linter would complain about the variable shadowing here.
alxndrsn
added a commit
to alxndrsn/odk-central-backend
that referenced
this pull request
Aug 3, 2022
Co-authored-by: alxndrsn <alxndrsn>
matthew-white
pushed a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: alxndrsn <alxndrsn> (cherry picked from commit a3a07f6)
2 tasks
ktuite
added a commit
that referenced
this pull request
Dec 1, 2023
ktuite
added a commit
that referenced
this pull request
Dec 7, 2023
* Tests showing failure * Separated entity-specific submission parsing code * Test demonstrating issue #522 * A test demonstrating issue #553 * Forcing /meta/entity field to be type structure * Tidying up tests to be clearer to read in the future * Tests to start looking at impact of empty structure entity field * More tests of odata * Removed console.log from exploratory test to make circleci happy * Small final test changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent failures in zip streams from cascading into other tests. See e.g. https://app.circleci.com/pipelines/github/getodk/central-backend/776/workflows/728fbdeb-7ff2-4b26-a4af-5561c76e53d1/jobs/1518