db.stream(): add timeout #566
Conversation
|
An alternative to setting a static timeout might be to re-set the timeout every time the stream is read from. This would mean that a long-running connection would be allowed to complete, but should still catch idle connections and allow them to be released. |
There was a problem hiding this comment.
It looks like we specify proxy_read_timeout 2m; in the production nginx config. From a look at the docs for proxy_read_timeout, it looks like that's two minutes between reads. Should we match those settings here?
Or thinking of a different approach entirely, does nginx indicate to Backend when nginx times out the request? If Backend could automatically detect that and clean up the request and its database connections then, that seems ideal. But I imagine that's easier said than done. 😅
Possible fix for #565.
Without fixing gajus/slonik#347 (e.g. with gajus/slonik#360), this will still result in hanging connections sometimes, but is still a significant improvement vs current
master.