Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-benchmark: switch final checks #638

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 11, 2022

Streams should time out after 2 minutes of inactivity, so we should wait for that before deciding if backend is correctly responding to login requests.

@alxndrsn alxndrsn marked this pull request as ready for review October 11, 2022 13:30
alxndrsn pushed a commit to alxndrsn/odk-central-backend that referenced this pull request Oct 11, 2022
Copy link
Contributor

@sadiqkhoja sadiqkhoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Streams should time out after 2 minutes of inactivity, so we should
wait for that before deciding if backend is correctly responding to
login requests.
@alxndrsn alxndrsn force-pushed the switch-benchmark-final-checks branch from 0ce3a48 to 8e33919 Compare October 13, 2022 12:18
@alxndrsn alxndrsn merged commit c200de1 into getodk:master Oct 13, 2022
@alxndrsn alxndrsn deleted the switch-benchmark-final-checks branch October 13, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants