Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: remove redundant indices from submission_defs table #805

Merged
merged 3 commits into from
Apr 24, 2023
Merged

enhance: remove redundant indices from submission_defs table #805

merged 3 commits into from
Apr 24, 2023

Commits on Apr 19, 2023

  1. enhance: remove redundant indices from submission_defs table 

    improves submission throughput by 20% without any impact on select queries

Benchmark:
250_questions form with 20K existing submissions
JMeter parameters:
300 thread
60 test duration
1500 per 10 sec target throughput
release 40 threads in batch

Result:
95/sec throughput with 4% error without this change
115/sec throughput without any error with this change
    @sadiqkhoja
    sadiqkhoja committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7f4f177 View commit details
    Browse the repository at this point in the history

  2. remove redundant indices from submissions table 

    add (createdAt, id) index on submission_defs
add (formId, createdAt, id) index on submissions
    @sadiqkhoja
    sadiqkhoja committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    1a2eba8 View commit details
    Browse the repository at this point in the history

  3. rename migration file to current date

    @sadiqkhoja
    sadiqkhoja committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    33da5fc View commit details
    Browse the repository at this point in the history