Add project settings to Collect QR codes #475
Conversation
| fullSettings() { | ||
| return { | ||
| general: { | ||
| ...this.settings, | ||
| server_url: `${window.location.origin}${this.settings.server_url}` | ||
| }, | ||
| // Collect requires the settings to have an `admin` property. | ||
| admin: {} | ||
| }; | ||
| }, |
There was a problem hiding this comment.
FieldKeyQrPanel and FormDraftTesting now do this work. I thought about leaving it here, but the code would have been surprisingly hairy, since settings now contains nested objects. I also think the new approach is a little clearer. Part of me doesn't love that FieldKeyQrPanel and FormDraftTesting now have some duplicate code, but it's just two components and not a lot of duplicate code. And probably we'll return to all this before too long once we start working on project settings.
| fieldKey: FieldKey, // eslint-disable-line vue/require-default-prop | ||
| managed: { | ||
| type: Boolean, | ||
| default: false | ||
| } |
There was a problem hiding this comment.
The linter no longer flags vue/require-default-prop, so this can be simplified.
| }; | ||
| }, | ||
| baseUrl() { |
There was a problem hiding this comment.
I randomly noticed that this computed property isn't used anywhere anymore! Probably it should have been removed as part of 43ceaa0.
Closes #474.