Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to download data template for uploading entities #933

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

matthew-white
Copy link
Member

Part of getodk/central#589.

What has been done to verify that this works as intended?

New tests, as well as trying out the button locally. I observed that a CSV file was downloaded with the expected content.

Why is this the best possible solution? Were any other approaches considered?

I thought about using URL.createObjectURL(), but a data URL seemed a little simpler.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white merged commit 43eaeb5 into master Feb 1, 2024
1 check passed
@matthew-white matthew-white deleted the entity-upload-template branch February 1, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants