Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pm2 from this repository #422

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Apr 26, 2023

Closes #336

Dependent on getodk/central-backend#848

What has been done to verify that this works as intended?

Tested locally

Why is this the best possible solution? Were any other approaches considered?

NA

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None, we have a circle CI step to verify whether multiple instances of pm2 are running or not

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

Before submitting this PR, please make sure you have:

  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

matthew-white and others added 2 commits March 24, 2023 18:07
as it is added in central-backend
@sadiqkhoja
Copy link
Contributor Author

we need to merge getodk/central-backend#848 first and then update server submodule

@sadiqkhoja sadiqkhoja marked this pull request as ready for review May 2, 2023 15:50
@matthew-white matthew-white linked an issue May 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move pm2 dependency to central-backend
2 participants