Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore docker-compose.override.yml #435

Merged
merged 1 commit into from
May 28, 2023
Merged

Ignore docker-compose.override.yml #435

merged 1 commit into from
May 28, 2023

Conversation

alanivey
Copy link
Contributor

Allow for overrides of docker-compose.yml without impacting git status.

Allow for overrides of docker-compose.yml without impacting git status.
@yanokwa
Copy link
Member

yanokwa commented May 26, 2023

@alanivey I'm curious, what are you typically overriding?

@alanivey
Copy link
Contributor Author

Setting logging for each service to send logs to Amazon CloudWatch, and making all named and anonymous volumes bind mounts to local directories for a few reasons (ease of backing up and restoring, being able to down+up the containers without losing LE certs)

@yanokwa yanokwa requested a review from lognaturel May 26, 2023 18:52
@yanokwa
Copy link
Member

yanokwa commented May 26, 2023

@alanivey Thanks for clarifying. I didn't know about docker-compose.override.yml and it's super helpful! If you come across other Docker best-practices that would be broadly useful to bake into Central, please do file issues.

@lognaturel This seems like a great change to me. It's a known convention.

@lognaturel
Copy link
Member

Thanks, @alanivey, this is great. I've also filed a follow-up docs issue: getodk/docs#1616

@alanivey alanivey deleted the ignore-docker-override branch May 29, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ done
Development

Successfully merging this pull request may close these issues.

3 participants