Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caused by android.database.sqlite.SQLiteException: Expression tree is too large (maximum depth 1000) (code 1) #1249

Merged
merged 4 commits into from
Jul 21, 2017
Merged

Caused by android.database.sqlite.SQLiteException: Expression tree is too large (maximum depth 1000) (code 1) #1249

merged 4 commits into from
Jul 21, 2017

Conversation

grzesiek2010
Copy link
Member

This PR is in reference to resolve #1231

@grzesiek2010
Copy link
Member Author

@mmarciniak Please test this pr really carefully:
-sending forms to Aggregate
-sending forms to Google Sheet (using new Google account or one with removed creditionals as well)
-autosend option to confirm that regression doesn't occur

This was referenced Jul 18, 2017
Closed
Closed
@mmarciniak90
Copy link
Contributor

Tested with success.
Tested on Android 4.1, 5.1, 6.0

  • Aggregate - I did not notice regression. User is able to send 1000 forms during one upload
  • Google Sheet - Crash does not occur. User is able to send 1000 forms during one upload
  • ODK Collect is not connected to Google account - User sees request to allow to connect app
    screenshot_20170718-140551
  • Autosend option - I did not notice regression
    Data needed to test issue: backup1249.zip

lognaturel
lognaturel reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One small naming change and I think this is ready to go.

collect_app/src/main/java/org/odk/collect/android/tasks/InstanceGoogleSheetsUploader.java Outdated
@@ -107,7 +119,7 @@ public InstanceGoogleSheetsUploader(GoogleAccountCredential credential) {
.build();
}

protected void uploadInstances(String selection, String[] selectionArgs, String token) {
protected void uploadInstances(String selection, String[] selectionArgs, String token, int low, int vauesCount) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vauesCount should be instanceCount I think.

@grzesiek2010
Copy link
Member Author

@lognaturel fixed.

@lognaturel lognaturel merged commit dbb8f13 into getodk:master Jul 21, 2017
@grzesiek2010 grzesiek2010 mentioned this pull request Aug 18, 2017
Closed
snavarreteimmap pushed a commit to snavarreteimmap/collect that referenced this pull request Oct 2, 2020
@grzesiek2010 @lognaturel
Fix crash when uploading many submissions to Google Sheets (getodk#1249)
09f9dc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caused by android.database.sqlite.SQLiteException: Expression tree is too large (maximum depth 1000) (code 1)
3 participants
@grzesiek2010 @mmarciniak90 @lognaturel