Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed touch tracking in the range slider #6612

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Feb 15, 2025

Closes #6607

Why is this the best possible solution? Were any other approaches considered?

The way we tracked touch events was incorrect. We set a listener and in that listener tried to call v.onTouchEvent(event) where v refers to the view that received the touch event. So it was like overriding the listener but also trying to call the default implementation and the order of those calls caused the problems with setting/reading values.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We need to test setting values in the range widgets (only those that use sliders, there is no need to test the picker one). Nothing else should be affected.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 added the high priority Should be looked at before other PRs/issues label Feb 15, 2025
@grzesiek2010 grzesiek2010 marked this pull request as ready for review February 15, 2025 20:13
@grzesiek2010 grzesiek2010 requested a review from seadowg February 15, 2025 20:13
@dbemke
Copy link

dbemke commented Feb 17, 2025

Tested with Success!

Verified on a device with Android 10

Verified cases:

@WKobus
Copy link

WKobus commented Feb 17, 2025

Tested with Success!

Verified on a device with Android 15

@grzesiek2010 grzesiek2010 merged commit 572b326 into getodk:master Feb 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number slider does not work as expected in the form with field list.
4 participants