Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the text roles #167

Merged
merged 3 commits into from
Sep 15, 2017
Merged

Documented the text roles #167

merged 3 commits into from
Sep 15, 2017

Conversation

troublemagnet
Copy link
Contributor

@troublemagnet troublemagnet commented Sep 15, 2017

Added the custom text roles section to sphinx-specific markup.
closes #113
closes #108

prooof

@adammichaelwood
Copy link
Contributor

Please do not do mass find-and-replace on a document. Ever.

  • There was no need to change the code-block language designations from rest to rst
  • Even if there was a reason, this PR was not the place to do it.
  • You caught the actual word "rest".

The role content itself is fine.

  • The issue Form states #113 specified an addition to custom.css, which is not included.
  • You do not need to change all the code block language declarations back at this point. However:
    • Please fix the places where the word "rest" (or other words) got mangled.

@troublemagnet
Copy link
Contributor Author

@adammichaelwood Sir the class style is already there in custom.css and I'm really sorry for the mass finding and replacing sir, I'll never do it again.

@adammichaelwood
Copy link
Contributor

Thanks. Good work.

@adammichaelwood adammichaelwood merged commit e7674ed into getodk:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form states document custom roles
3 participants