Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line edit documentation #516

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Line edit documentation #516

merged 1 commit into from
Feb 12, 2018

Conversation

LSRafay
Copy link
Contributor

@LSRafay LSRafay commented Feb 10, 2018

addresses # 96

What is included in this PR?

Simple line edit to correct three instances of a capitalization mistake in documentation: css to CSS.

What problems did you encounter?

I am not a computer scientist and am still learning to use GitHub and Git Bash on Windows. I attempted to make this line edit using the command line but ran into some errors that I am still trying to sort out for future contributions. For now I have used GitDesktop to submit my contribution, but I know this is not canonical and that I will need to learn to use Git Bash effectively. I am locating online resources to help me address the command line difficulties I am having so that I may do this the standard way in the future. (I also realize that I need to learn more about the system ODK uses for attaching a PR to an open issue. My apologies for not know what information to put down for that on this first try.) Thank you ODK community for your patience and inclusiveness!

@ankita240796
Copy link
Contributor

ankita240796 commented Feb 10, 2018

Hi @LSRafay, can you please change your PR comment to include addresses #96 and remove the closes# line.
You can go through the contributor's guide to get started easily. Feel free to share any issues you run into.

@@ -100,13 +100,13 @@ It is helpful to keep the CSS file organized.
There are several sections in the :file:`custom.css` file:

- Styling for rst roles and directives
- Responsive css
- Responsive CSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adammichaelwood
Copy link
Contributor

@LSRafay Thanks for the edit. Merging.

It looks like your editor is automatically deleting trailing whitespace.
(This is a setting that you can turn on and off in most browsers.)

It's not a big deal, but it is easier to read pull requests when this setting is turned off.
There are some rare cases, too, where having it turned on can cause problems.

@adammichaelwood adammichaelwood merged commit bc2f1ed into getodk:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants