Explicitly identify the value that can't be converted to a date #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #405
What has been done to verify that this works as intended?
Added tests to make sure the exceptions are thrown when expected.
Why is this the best possible solution? Were any other approaches considered?
In Collect, these exception messages will be shown to the user in a dialog if re-computation leads to an invalid value being passed to a function that converts to date. These error messages should help the user identify what form design improvements they could make to avoid that case without making them too long. I considered providing suggestions like adding constraints or defaults but I think it's too hard to make generically useful.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
All this should do is improve error text.
Do we need any specific form for testing your changes? If so, please attach one.
decimal-date-time-bug.xls.zip
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.