jr:count value should always be coerced to number #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Aug 9, 2024
|
I think this should be tested, do you agree @seadowg? |
|
@grzesiek2010 yup sounds good! |
eyelidlessness
added a commit
to getodk/web-forms
that referenced
this pull request
Dec 11, 2024
Update is consistent with getodk/javarosa#789
eyelidlessness
added a commit
to getodk/web-forms
that referenced
this pull request
Dec 12, 2024
Update is consistent with getodk/javarosa#789
eyelidlessness
added a commit
to getodk/web-forms
that referenced
this pull request
Dec 12, 2024
Update is consistent with getodk/javarosa#789
eyelidlessness
added a commit
to getodk/web-forms
that referenced
this pull request
Dec 13, 2024
Update is consistent with getodk/javarosa#789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #783
What has been done to verify that this works as intended?
I've improved automated tests and performed manual ones using the form attached below.
Why is this the best possible solution? Were any other approaches considered?
This improved
AnswerDataUtil#answerDataToIntso that it supports parsingStringDatato integers. It was a missing piece and that's why it was not possible to use numbers from an external CSV inrepeat_count.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just add support for using numbers from an external CSV in
repeat_count, nothing else should be affected.Do we need any specific form for testing your changes? If so, please attach one.
I've used this:
families.csv
families_form.xlsx
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.