fix - missing total token count calculation for maintain_format = False #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@annapo23, @tylermaran, @xdotli Could you please review this PR? |
@pradhyumna85 taking a look now |
tylermaran
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Hey @pradhyumna85, good catch and this one looks pretty simple!
Going to go ahead and merge.
| @@ -123,6 +123,10 @@ async def zerox( | |||
|
|
|||
| aggregated_markdown = [result[0] for result in results if isinstance(result[0], str)] | |||
|
|
|||
| ## add token usage | |||
namtho7078
pushed a commit
to namtho7078/zerox
that referenced
this pull request
Oct 27, 2024
…se (getomni-ai#32) Co-authored-by: Pradyumna Singh Rathore <pradyumna.singhrathore@halliburton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31