Page ordering/sorting fix, fix to use unique temp dir if userinput not provided also with better cleanup, added async shutil (aioshutil) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 12, 2024 13:25
…ely function to do a expected alphanumeric sort.
… Replaces zerox ouput for python sdk with updated output containing token counts. - Fixing page order issue by adding alphanumeric human like sorting utility (doesn't require padding). Fixes Issue getomni-ai#25 - Better way of handling tmp_dir - user input or unique named temperory directory if None
…util.rmtree calls with async ones
pradhyumna85
changed the title
tylermaran
reviewed
Sep 12, 2024
tylermaran
reviewed
Sep 12, 2024
tylermaran
reviewed
Sep 12, 2024
added 4 commits
September 13, 2024 02:25
…pped python example output)
…r-fixes - Padding logic removed as not required after sorted_nicely function implementation.
…ion implementation.
pradhyumna85
commented
Sep 12, 2024
There was a problem hiding this comment.
@tylermaran, All review threads incorporated. pip install verified, tested imports locally also. Ready to merge!
|
@tylermaran, I think you'll need to create a release to trigger the pypi publishing action to publish newer python package to pypi? |
namtho7078
pushed a commit
to namtho7078/zerox
that referenced
this pull request
Oct 27, 2024
…t provided also with better cleanup, added async shutil (aioshutil) (getomni-ai#34) * Fixed page order issue, fixed tempdir cleanup issue, added sorted nicely function to do a expected alphanumeric sort. * fix token usage counting which is not aggrefated correctly and always returned 0 * minor fix in token count aggregation * make more concise * - update missing minor documentation changes for Issue getomni-ai#31. Replaces zerox ouput for python sdk with updated output containing token counts. - Fixing page order issue by adding alphanumeric human like sorting utility (doesn't require padding). Fixes Issue getomni-ai#25 - Better way of handling tmp_dir - user input or unique named temperory directory if None * added asyncronous shutil (aioshutil) and replaced older syncronous shutil.rmtree calls with async ones * bump pysdk version * fix import in python sdk documentation * update importable name to pyzerox. Update documentation (manually wrapped python example output) * removed padding logic (not required anymore after sorted_nicely function implementation. * minor typo fix for token count --------- Co-authored-by: Pradyumna Singh Rathore <pradyumna.singhrathore@halliburton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not required now with this PR)Changes
So this PR is no longer required)Note: PR #26 is no longer required as this PR incorporates its ideas plus other minor fixes also all together.