feat: Add Pointer Package #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredallard
reviewed
Nov 15, 2023
jaredallard
approved these changes
Nov 16, 2023
antonaudzei-outreach
approved these changes
Nov 20, 2023
|
🎉 This PR is included in version 1.83.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR aims to add a pointer package to be used across our services and librairies.
I had to do pointer conversion in API-Proxy here and saw
ptr.SomeType()in several places (not using generic).As we are using gql federation in our services we will surely need more pointer conversion and I would like to have the possibility to use generics.
Jira ID
No Jira, just an idea of package that would be nice to have
Notes for your reviewers