Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Moving to go 1.23, fixing .tool-versions/settings.json #135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deregtd
Copy link
Contributor

@deregtd deregtd commented Aug 18, 2024

This fixes lintroller for folks who have upgraded to go 1.23 and getting errors like this:

[lint] $ lintroller -config lintroller.yaml ./...
somefile.go:2:1: package requires newer Go version go1.23
-: This application uses version go1.22 of the source-processing packages but runs version go1.23 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.

I also fixed up the tool-versions/settings.json that are unnecessarily pulling in protoc/terraform modules

@deregtd deregtd requested a review from a team as a code owner August 18, 2024 04:19
.tool-versions Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants