Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursive and other changes. #711

Merged
merged 4 commits into from
Jul 17, 2019

Conversation

JayjeetAtGithub
Copy link
Collaborator

@JayjeetAtGithub JayjeetAtGithub commented Jul 12, 2019

Remove --recursive option for Popper CLI

@pep8speaks
Copy link

pep8speaks commented Jul 12, 2019

Hello @JayjeetAtGithub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-17 17:25:29 UTC

@JayjeetAtGithub JayjeetAtGithub force-pushed the jayjeet/depr_recursive branch from 3c4d140 to 679faca Compare July 12, 2019 20:00
@JayjeetAtGithub JayjeetAtGithub changed the title Jayjeet/depr recursive Remove recursive and other changes. Jul 12, 2019
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review July 15, 2019 12:06
@JayjeetAtGithub JayjeetAtGithub requested a review from ivotron July 15, 2019 19:08
cli/popper/commands/cmd_run.py Outdated Show resolved Hide resolved
@JayjeetAtGithub JayjeetAtGithub requested a review from ivotron July 16, 2019 14:07

1. When no TARGET argument is passed, Popper will search for the
When no action argument is passed, Popper will search for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should read:

By default, Popper searches for a workflow in .github/main.workflow or ./main.workflow and it executes it if found.

@JayjeetAtGithub JayjeetAtGithub force-pushed the jayjeet/depr_recursive branch from b366601 to ed0bbe3 Compare July 17, 2019 16:35
@JayjeetAtGithub JayjeetAtGithub force-pushed the jayjeet/depr_recursive branch from ed0bbe3 to 6f795a5 Compare July 17, 2019 16:39
@JayjeetAtGithub JayjeetAtGithub requested a review from ivotron July 17, 2019 18:04
@ivotron ivotron merged commit 79046bf into getpopper:master Jul 17, 2019
ivotron pushed a commit that referenced this pull request Jul 23, 2019
running workflows recursively is now only done when CI=true is defined
@JayjeetAtGithub JayjeetAtGithub deleted the jayjeet/depr_recursive branch August 17, 2019 07:29
ivotron pushed a commit that referenced this pull request May 24, 2020
running workflows recursively is now only done when CI=true is defined
ivotron pushed a commit that referenced this pull request May 25, 2020
running workflows recursively is now only done when CI=true is defined
ivotron pushed a commit that referenced this pull request May 25, 2020
running workflows recursively is now only done when CI=true is defined
ivotron pushed a commit that referenced this pull request May 25, 2020
running workflows recursively is now only done when CI=true is defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants