Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inject pre/post action #712

Merged
merged 6 commits into from
Jul 17, 2019
Merged

inject pre/post action #712

merged 6 commits into from
Jul 17, 2019

Conversation

arshul
Copy link
Contributor

@arshul arshul commented Jul 15, 2019 •
edited
Loading

Actions can be injected via POPPER_PRE_WORKFLOW_PATH and POPPER_POST_WORKFLOW_PATH environment variables pointing to valid .workflow files. PRE workflow would be executed before the main workflow and POST workflow will get executed after the main workflow.

@pep8speaks
Copy link

pep8speaks commented Jul 15, 2019 •
edited
Loading

Hello @arshul! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-17 06:55:48 UTC

ivotron
ivotron requested changes Jul 17, 2019
View reviewed changes
cli/popper/commands/cmd_run.py Outdated Show resolved Hide resolved
cli/popper/commands/cmd_run.py Outdated Show resolved Hide resolved
@arshul
PEP8 fixes
8b8b095 
[skip ci]
@ivotron ivotron merged commit f8ceabd into master Jul 17, 2019
@ivotron ivotron deleted the inject_actions branch July 17, 2019 07:12
ivotron pushed a commit that referenced this pull request Jul 23, 2019
@arshul @ivotron
inject pre/post action (#712)
f52b971 
Adds mechanism for injecting pre- and post-execution workflows.

fixes #709
ivotron pushed a commit that referenced this pull request May 24, 2020
@arshul @ivotron
inject pre/post action (#712)
6bec090 
Adds mechanism for injecting pre- and post-execution workflows.

fixes #709
ivotron pushed a commit that referenced this pull request May 25, 2020
@arshul @ivotron
inject pre/post action (#712)
0fee54c 
Adds mechanism for injecting pre- and post-execution workflows.

fixes #709
ivotron pushed a commit that referenced this pull request May 25, 2020
@arshul @ivotron
inject pre/post action (#712)
f49e3cf 
Adds mechanism for injecting pre- and post-execution workflows.

fixes #709
ivotron pushed a commit that referenced this pull request May 25, 2020
@arshul @ivotron
inject pre/post action (#712)
a684371 
Adds mechanism for injecting pre- and post-execution workflows.

fixes #709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arshul @pep8speaks @ivotron