-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slurm tweaks #802
slurm tweaks #802
Conversation
[skip ci]
Adds an argument to DockerRunner to skip initializing the docker client
@ivotron LGTM. I would fix the tests soon. |
Hello @ivotron! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-04-15 17:18:50 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really cool, thanks a lot for your time! please take a look at the comments
3db9e26
to
2b8f184
Compare
0814645
to
fbdd346
Compare
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py). also fixes #767 Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py). also fixes #767 Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py). also fixes #767 Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py). also fixes #767 Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
several tweaks to slurm runner, along with refactoring of parent classes (runner.py and runner_host.py)