Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slurm tweaks #802

Merged
merged 66 commits into from
Apr 15, 2020
Merged

slurm tweaks #802

merged 66 commits into from
Apr 15, 2020

Conversation

ivotron
Copy link
Collaborator

@ivotron ivotron commented Apr 8, 2020

several tweaks to slurm runner, along with refactoring of parent classes (runner.py and runner_host.py)

@ivotron ivotron requested a review from JayjeetAtGithub April 8, 2020 09:12
@JayjeetAtGithub
Copy link
Collaborator

JayjeetAtGithub commented Apr 8, 2020

@ivotron LGTM. I would fix the tests soon.

@pep8speaks
Copy link

pep8speaks commented Apr 8, 2020

Hello @ivotron! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 188:80: E501 line too long (91 > 79 characters)
Line 202:80: E501 line too long (80 > 79 characters)

Line 283:80: E501 line too long (108 > 79 characters)
Line 284:80: E501 line too long (281 > 79 characters)

Comment last updated at 2020-04-15 17:18:50 UTC

Copy link
Collaborator Author

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, thanks a lot for your time! please take a look at the comments

cli/popper/config.py Show resolved Hide resolved
cli/popper/runner_host.py Outdated Show resolved Hide resolved
cli/popper/runner_host.py Outdated Show resolved Hide resolved
cli/popper/runner_slurm.py Show resolved Hide resolved
cli/popper/runner_host.py Show resolved Hide resolved
cli/test/test_runner_slurm.py Outdated Show resolved Hide resolved
cli/test/test_runner_slurm.py Outdated Show resolved Hide resolved
cli/test/test_runner_slurm.py Outdated Show resolved Hide resolved
cli/test/test_runner_slurm.py Show resolved Hide resolved
cli/test/test_runner_slurm.py Show resolved Hide resolved
@ivotron ivotron merged commit 82cca37 into master Apr 15, 2020
@ivotron ivotron deleted the slurm-tweaks branch April 15, 2020 20:52
cli/setup.py Show resolved Hide resolved
cli/test/test_runner_host.py Show resolved Hide resolved
ivotron added a commit that referenced this pull request May 24, 2020
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py).

also fixes #767

Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
ivotron added a commit that referenced this pull request May 25, 2020
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py).

also fixes #767

Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
ivotron added a commit that referenced this pull request May 25, 2020
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py).

also fixes #767

Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
ivotron added a commit that referenced this pull request May 25, 2020
miscellaneous tweaks to the slurm runner, along with refactoring of parent classes (runner.py and runner_host.py).

also fixes #767

Co-authored-by: Jayjeet Chakraborty <jc.github@rediffmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants