address PR feedback

Signed-off-by: Brian DeGeeter <b.degeeter@f5.com>

tests/integration/credset_test.go

@@ -253,7 +253,8 @@ func NewTestCredSet(csName string) *porterv1.CredentialSet {
 		},
 		Spec: porterv1.CredentialSetSpec{
 			//TODO: get schema version from porter version?
-			SchemaVersion: schemaVersion,
+			// https://github.com/getporter/porter/pull/2052
+			SchemaVersion: "1.0.1",
 			Name:          csName,
 		},
 	}
@@ -288,7 +289,7 @@ func NewTestInstallation(iName string) *porterv1.Installation {
 			GenerateName: "porter-test-me-",
 		},
 		Spec: porterv1.InstallationSpec{
-			SchemaVersion: schemaVersion,
+			SchemaVersion: "1.0.1",
 			Name:          iName,
 			Bundle: porterv1.OCIReferenceParts{
 				Repository: "ghcr.io/bdegeeter/porter-test-me",

tests/integration/suite_test.go

@@ -37,7 +37,6 @@ import (
 var cfg *rest.Config
 var k8sClient client.Client
 var testEnv *envtest.Environment
-var schemaVersion string
 
 func TestAPIs(t *testing.T) {
 	RegisterFailHandler(Fail)
@@ -115,18 +114,6 @@ var _ = AfterSuite(func() {
 	Expect(err).NotTo(HaveOccurred())
 })
 
-var _ = BeforeEach(func() {
-	schemaVersion = "1.0.1"
-}, 5)
-
-var _ = AfterEach(func() {
-	if _, ok := os.LookupEnv("KEEP_TESTS"); ok {
-		return
-	}
-	//TODO: don't reuse namespace for all tests move this to suite/magefile cleanup
-	//deleteNamespace(testNamespace)
-}, 5)
-
 func createTestNamespace(ctx context.Context) string {
 	ns := &v1.Namespace{
 		ObjectMeta: metav1.ObjectMeta{

tests/integration/testdata/operator_porter_config.yaml

@@ -1,4 +1,3 @@
-#TODO: remove this file
 debug: true
 debug-plugins: true
 default-secrets: "kubernetes-secrets"