Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PorterConfig type to use verbosity instead of debug and debug… #114

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

sgettys
Copy link
Collaborator

@sgettys sgettys commented Aug 31, 2022

…-plugins

Signed-off-by: Steven Gettys s.gettys@f5.com

…-plugins

Signed-off-by: Steven Gettys <s.gettys@f5.com>
@sgettys sgettys requested a review from carolynvs August 31, 2022 21:56
@sgettys
Copy link
Collaborator Author

sgettys commented Aug 31, 2022

Closes #112 and #113

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #114 (fcee485) into main (87a2f0c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files          12       12           
  Lines         976      976           
=======================================
  Hits          762      762           
  Misses        136      136           
  Partials       78       78           
Flag Coverage Δ
unit-tests 78.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1/porterconfig_types.go 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

api/v1/porterconfig_types.go Show resolved Hide resolved
docs/content/file-formats.md Outdated Show resolved Hide resolved
@@ -278,6 +278,28 @@ Let's walk through the second method in detail.
Digest: sha256:22cdfad0756c9ce1a8f4694b0411440dfab99fa2e07125ff78efe555dd63d73e
```

## Environment Configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: Steven Gettys <s.gettys@f5.com>
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@carolynvs carolynvs merged commit 8419997 into getporter:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants