add repo setup files #151
add repo setup files #151
Conversation
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
| ``` | ||
|
|
||
| ## Version | ||
| Please provide the porter-agent and the operator version number that's used to reproduce the bug |
There was a problem hiding this comment.
Let's ask for their AgentConfig since that will give us the versions and all the extra info we need to debug.
| If applicable, provide potential implementation details assuming the proposal is accepted. | ||
|
|
||
| # Checklist | ||
| - [ ] An announcement of this proposal has been sent to the Porter mailing list: https://getporter.org/mailing-list |
There was a problem hiding this comment.
These requirements are more for big stuff like PEPs. Let's remove them from this template since most stuff won't need it and we can ask for a PEP if it's really big.
.github/pull_request_template.md
Outdated
| - [ ] Did you write tests? | ||
| - [ ] Did you write documentation? | ||
| - [ ] Did you make any API changes? Update the corresponding API documentation. | ||
| - [ ] If this is your first pull request, please add your name to the bottom of our [Contributors][contributors] list. Thank you for making Porter better! 🙇♀️ |
There was a problem hiding this comment.
It's awkward to tell them to open a second PR against the porter repo, so maybe just leave that off for now? Otherwise we need to be clear it's a separate PR in the core Porter repo that should be opened after their PR here is merged.
.github/pull_request_template.md
Outdated
| - [ ] If this is your first pull request, please add your name to the bottom of our [Contributors][contributors] list. Thank you for making Porter better! 🙇♀️ | ||
|
|
||
| # Reviewer Checklist | ||
| * Comment with /azp run test-porter-release if a magefile or build script was modified |
There was a problem hiding this comment.
These instructions don't apply to this repo
CONTRIBUTION_LADDER.md
Outdated
| @@ -0,0 +1,105 @@ | |||
| # Contribution Ladder | |||
There was a problem hiding this comment.
I would rather link people to a common ladder in Porter's main repo so that we aren't maintaining separate copies of this content, which is getting stale and will need to be updated soon. Let's figure out where this is linked to from our repo, and just link directly to the core porter repo ladder.
config/CODE_OF_CONDUCT.md
Outdated
| @@ -0,0 +1,75 @@ | |||
| # Contributor Covenant Code of Conduct | |||
There was a problem hiding this comment.
The CoC is already in the root of the repo, looks like this was added by mistake?
.github/pull_request_template.md
Outdated
|
|
||
| # Reviewer Checklist | ||
| * Comment with /azp run test-porter-release if a magefile or build script was modified | ||
| * Comment with /azp run porter-integration if it's a non-trivial PR |
There was a problem hiding this comment.
Sorry I wasn't clear, we should just remove the entire Reviewer checklist. There isn't a "azp run porter-integration" support on the operator repo at all. It's only a thing for the core repo.
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
This PR adds templates and repo setup files
related issue: #146