Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates sync to 0.3.0 without downgrading controller-runtime #226

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

troy0820
Copy link
Member

What does this change

Updates sync to 0.3.0 without downgrading controller-runtime to 0.14.6

What issue does it fix

Closes #216

Notes for the reviewer

None

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you make any API changes? Update the corresponding API documentation.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #226 (4852631) into main (6306b6f) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   69.92%   69.35%   -0.58%     
==========================================
  Files          13       13              
  Lines        1556     2160     +604     
==========================================
+ Hits         1088     1498     +410     
- Misses        350      544     +194     
  Partials      118      118              
Flag Coverage Δ
unit-tests ?
unittests 69.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@troy0820 troy0820 force-pushed the troy0820/sync-to-0.3.0 branch from 98435af to 78f85a2 Compare July 13, 2023 15:47
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/sync-to-0.3.0 branch from 78f85a2 to 4852631 Compare July 13, 2023 16:38
@troy0820
Copy link
Member Author

image

Love it, no files were changed but coverage changed.

@schristoff schristoff merged commit 8f932b9 into getporter:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants