(feat): Add TTLSecondsAfterFinished with a default of 600 seconds #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
schristoff
requested review from
sgettys,
bdegeeter and
troy0820
as code owners
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
+ Coverage 71.78% 71.82% +0.03%
==========================================
Files 14 14
Lines 2162 2165 +3
==========================================
+ Hits 1552 1555 +3
Misses 477 477
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
arschles
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #248 into two different pieces.
This piece closes issue #134