-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create grpc connection only on invocation of the CRUD events for the installation controller #328
Merged
troy0820
merged 6 commits into
getporter:main
from
troy0820:troy0820/update-grpc-invocation
Jun 10, 2024
Merged
Create grpc connection only on invocation of the CRUD events for the installation controller #328
troy0820
merged 6 commits into
getporter:main
from
troy0820:troy0820/update-grpc-invocation
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allation Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
troy0820
commented
Jun 3, 2024
troy0820
commented
Jun 3, 2024
troy0820
commented
Jun 3, 2024
troy0820
commented
Jun 3, 2024
troy0820
commented
Jun 3, 2024
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
troy0820
force-pushed
the
troy0820/update-grpc-invocation
branch
from
June 3, 2024 22:33
7f8d2be
to
afcf868
Compare
troy0820
commented
Jun 4, 2024
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
sgettys
reviewed
Jun 8, 2024
…e ClientConn interface, create mocks, update tests Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
troy0820
commented
Jun 9, 2024
troy0820
commented
Jun 9, 2024
troy0820
commented
Jun 9, 2024
troy0820
commented
Jun 9, 2024
troy0820
commented
Jun 9, 2024
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
sgettys
reviewed
Jun 9, 2024
sgettys
approved these changes
Jun 9, 2024
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we were creating a persistent connection with the grpc server when starting the controller manager. This led to problems decoupling that connection when starting the operator. Now this connection will only be established if the creation/update of an installation is done. This will reduce the overhead of that established connection as well as not being able to reestablish this connection on subsequent calls if not done at startup.
What does this change
What issue does it fix
No issue but discussed during the maintainers call
Notes for the reviewer
This doesn't impact anything as this image shows that this still works, just changes the implementation around how we establish a connection with the grpc server
Checklist
Existing tests verify nothing has changed.