Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create grpc connection only on invocation of the CRUD events for the installation controller #328

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jun 3, 2024

Before this change we were creating a persistent connection with the grpc server when starting the controller manager. This led to problems decoupling that connection when starting the operator. Now this connection will only be established if the creation/update of an installation is done. This will reduce the overhead of that established connection as well as not being able to reestablish this connection on subsequent calls if not done at startup.

What does this change

  • Creates the grpc connection when the controller is invoked on a CRUD event for the installation controller

What issue does it fix

No issue but discussed during the maintainers call

Notes for the reviewer

This doesn't impact anything as this image shows that this still works, just changes the implementation around how we establish a connection with the grpc server
image

Checklist

  • Did you write tests? Existing tests verify nothing has changed.
  • Did you write documentation?
  • Did you make any API changes? Update the corresponding API documentation.

…allation

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 force-pushed the troy0820/update-grpc-invocation branch from 7f8d2be to afcf868 Compare June 3, 2024 22:33
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
…e ClientConn interface, create mocks, update tests

Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
main.go Show resolved Hide resolved
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
@troy0820 troy0820 merged commit 46f4010 into getporter:main Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants