Sync v1 branch with main #1669
Merged
Sync v1 branch with main #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
carolynvs
commented
Jul 12, 2021
carolynvs
commented
- Merge pull request Fix applyTo check for outputs in porter explain #1668 from carolynvs/fix-explain-outputs
- Merge pull request Add bundle use cases to homepage #1657 from carolynvs/homepage
- Merge pull request Fix go.mod entry for jsonschema #1655 from carolynvs/fix-go-mod
- Blog: Helm v2 rename (Blog: Helm v2 rename #1654)
* Blog: Helm v2 rename Announce the helm -> helm2 rename and tell people to upgrade to helm3. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Fix typo Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> Co-authored-by: Vaughn Dice <vadice@microsoft.com> Co-authored-by: Vaughn Dice <vadice@microsoft.com>
I submitted my fix upstream and had to rebase so the reference to the PR in our go.mod file changed. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
* make the font larger * fix padding of list items Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Fix go.mod entry for jsonschema
Add bundle use cases to homepage
I have consolidated the logic for checking if a scoped item: parameter, credential or output, should be included in the output of explain to avoid errors when duplicating the logic for each one. There was also a copy/paste of the appliesTo logic for ParameterDefinition (our def of a parameter in the porter manifest) that I updated to implement Scoped so that we can hopefully avoid more problems with this type of check. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Fix applyTo check for outputs in porter explain
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
vdice
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.