Sync v1 #1840
Merged
Sync v1 #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update parameters doc with allowable types Signed-off-by: “adnan” <adnankhan021@gmail.com> * to squash: address wording issues Signed-off-by: “adnan” <adnankhan021@gmail.com> * to squash: add parameters-type section Signed-off-by: “adnan” <adnankhan021@gmail.com>
Signed-off-by: Parmeshwar Patidar <prm.mehul@gmail.com>
docs: fix command in contrib tutorial
When cnab-to-oci fixes up a bundle after publishing it, if any error occurs we only get a single error message "failed to fixup the image for service InvocationImage" This bumps our cnab-to-oci to use the patch in cnabio/cnab-to-oci#113 so that we get a more detailed error message that indicates the image that failed, and which fixup step. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Improve error message when cnab-to-oci fixes up a bundle
Signed-off-by: Avinash Upadhyaya <avinashupadhya99@gmail.com>
Signed-off-by: Avinash Upadhyaya <avinashupadhya99@gmail.com>
…d-fix Doc packr word fix
* adding PushBundleWithRelocationMap function Signed-off-by: Anjay Ajodha <anajod@microsoft.com> * Add a smoke test for porter copy Validate that we are using the relocation map when copying the bundle. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Cherry-pick test improvements from main I've cherry-picked some test improvements from main to help with the new porter copy test: * track the repo root and always use absolute paths to avoid problems caused by tests that change directories I've also added the last assert in the copy test that was accidentally not included in the prior commit. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Added reloMap parameter into PushBundle * Initialize relocation map before pushing * Ensure that the relocation map is initialized (not null) before calling into cnab-to-oci since it assumes the map is not null Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Remove unused test helper We refactored the existing function so this variation isn't needed anymore. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> Co-authored-by: Carolyn Van Slyck <me@carolynvanslyck.com>
* Fix Pushing Bundles that have a relocationMap (getporter#1815) * chore: add avinashupadhya99 to Contributors.md * docs: remove accidental packr word from contribution guide * Improve error message when cnab-to-oci fixes up a bundle * docs: fix command in contrib tutorial * docs: update parameters doc with allowable types (getporter#1792) Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch 'main' into release/v1