Allow mixins to ignore a failed command #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
mixin-handle-error
branch
from
eb932f0 to
97e95ab
Compare
carolynvs
commented
Jan 4, 2022
| @@ -71,6 +71,8 @@ func NewTestCommand(c *Context) CommandBuilder { | |||
| cmd.Env = []string{ | |||
| fmt.Sprintf("%s=true", test.MockedCommandEnv), | |||
| fmt.Sprintf("%s=%s", test.ExpectedCommandEnv, c.Getenv(test.ExpectedCommandEnv)), | |||
| fmt.Sprintf("%s=%s", test.ExpectedCommandExitCodeEnv, c.Getenv(test.ExpectedCommandExitCodeEnv)), | |||
There was a problem hiding this comment.
I added these so that we can simulate a command failing in our unit tests.
Add the HasErrorHandling interface to the shared pkg/exec/builder package used by all the mixins. When implemented, a mixin can examine a failed command and optionaly handle it. The exec mixin now supports ignoring failed commands, which demonstrates how to use builder.IgnoreErrorHandler struct to use the same error handling behavior. Closes getporter#592 Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
mixin-handle-error
branch
from
97e95ab to
1dbca54
Compare
|
/azp run porter-integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vdice
approved these changes
Jan 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add the HasErrorHandling interface to the shared pkg/exec/builder
package used by all the mixins. When implemented, a mixin can examine a
failed command and optionally handle it.
The exec mixin now supports ignoring failed commands, which demonstrates
how to use builder.IgnoreErrorHandler struct to use the same error
handling behavior.
Here is the updated doc for the exec mixin: https://deploy-preview-1846--porter.netlify.app/mixins/exec/. I have added comments to the sample yaml config, and a section about ignoring errors.
What issue does it fix
Closes #592
Notes for the reviewer
I am working on a PR for the az mixin that uses this to make resource groups and handle errors when it already exists. getporter/az-mixin#34
Checklist