fix edge cases in docs #2024
Merged
fix edge cases in docs #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quentin Petraroia <q.petraroia@gmail.com>
qpetraroia
requested review from
carolynvs,
jeremyrickard and
vdice
as code owners
carolynvs
approved these changes
Apr 19, 2022
| @@ -394,6 +394,8 @@ Hello Carolyn! | |||
| That verifies your change but let's also run the [unit tests] and [end-to-end] tests | |||
| to make sure there aren't any regressions. | |||
|
|
|||
| > In MacOS Monterey, port 5000 is already in use blocking `mage testSmoke` from running properly. To free port 5000, uncheck `AirPlay Receiver` in Sharing under System Preferences. | |||
There was a problem hiding this comment.
Thanks for adding this! I ran into the same problem myself but then immediately forgot that I had to do that.
There was a problem hiding this comment.
I know right!? It was driving me crazy LOL!
|
@qpetraroia Would you like to add your name to our CONTRIBUTORS page as part of this PR before I merge it? You can always add it later if you like. |
Yep, I will do this later tonight! |
Signed-off-by: Quentin Petraroia <q.petraroia@gmail.com>
|
@carolynvs added myself to the list :) looking forward to contributing more in my spare time! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
I recently got Porter running on my M1 mac. During my set up, I ran into a couple of problems. One being using the wrong prerelease version of Porter as well as port 5000 being blocked by Mac OS Monterey.
For example if it introduces a new command or modifies a commands output, give an example of you running the command and showing real output here.
What issue does it fix
Closes # (issue)
If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.
Notes for the reviewer
Put any questions or notes for the reviewer here.
Checklist
Reviewer Checklist