Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build-driver config setting #2114

Merged
merged 1 commit into from
May 31, 2022

Conversation

carolynvs
Copy link
Member

What does this change

I found a few spots I missed when removing docker from the build-driver options.

What issue does it fix

Follow-up to #1999

Notes for the reviewer

We have plans for adding another build driver in the future: podman. That's why we aren't just removing the build-driver option entirely.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

I found a few spots I missed when removing docker from the build-driver
options.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs requested a review from VinozzZ May 31, 2022 13:55
@carolynvs carolynvs marked this pull request as ready for review May 31, 2022 14:18
@carolynvs carolynvs merged commit 452632d into getporter:release/v1 May 31, 2022
@carolynvs carolynvs deleted the cleanup-build-driver branch May 31, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants