Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change dependency schema in porter #2117

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented May 31, 2022

What does this change

This PR updates the dependency schema to prepare for the advanced dependency feature
https://github.com/getporter/proposals/blob/main/pep/003-dependency-namespaces-and-labels.md#porteryaml

What issue does it fix

Notes for the reviewer

We want to make this change before v1 release so that users don't have to do another schema update immediately after v1

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
@VinozzZ VinozzZ force-pushed the change-denpendency-schema branch from 70f78f5 to 8c50bf0 Compare May 31, 2022 17:21
VinozzZ added 2 commits June 1, 2022 17:19
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
@VinozzZ VinozzZ marked this pull request as ready for review June 2, 2022 21:39
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off on merging until the integration tests are fixed in #2129 (working on that now).

@carolynvs
Copy link
Member

Oh nevermind, it's just the main branch that is affected by that issue.

@carolynvs carolynvs merged commit a13b349 into getporter:release/v1 Jun 3, 2022
@carolynvs carolynvs added the pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants