Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the Github actions file #46

Closed

Conversation

Bharadwajshivam28
Copy link

Hey @schristoff I have modified the action file and here the Golang version is used from env avoid installing it everytime . Just a small question that should I seperate the file one on push and one on Pull Request?

Signed-off-by: shivam <shivambharadwaj822@gmail.com>
@schristoff
Copy link
Member

Hey,
Yeah I think it makes sense to have one that runs on pull requests and one that runs on merge into main (push into main)
The push into main one would have the publish built into it

    - name: Publish
      if: success() && github.event_name != 'PullRequest'
      env:
        GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
      run: mage Publish

@Bharadwajshivam28
Copy link
Author

Hey, Yeah I think it makes sense to have one that runs on pull requests and one that runs on merge into main (push into main) The push into main one would have the publish built into it

    - name: Publish
      if: success() && github.event_name != 'PullRequest'
      env:
        GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
      run: mage Publish

Okay I will make the changes requried

Signed-off-by: shivam <shivambharadwaj822@gmail.com>
@Bharadwajshivam28
Copy link
Author

Hey @schristoff I have seperated 2 files one for push and another on pull request also changed the file names .

@kichristensen
Copy link
Contributor

This was implemented in #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants