Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add custom action support #19

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Aug 10, 2019

  • adds custom action support (porter invoke --action <action>)
  • removes status command now that it is superseded by added custom action support
  • adds a basic example demonstrating use of custom actions
  • adds/updates mixin schema and adds validation tests

Closes #14

@vdice vdice changed the title Feat/add custom action support feat(*): add custom action support Aug 10, 2019
@vdice vdice force-pushed the feat/add-custom-action-support branch from ba91c1d to 0dc48e9 Compare August 19, 2019 20:20
@vdice vdice requested a review from carolynvs August 19, 2019 20:20
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. One more thing that you'll want is VSCode support so that you get autocomplete for custom actions.

Here's what that looks like in the exec mixins:

https://github.com/deislabs/porter/blob/0652b3af4c19c63e695ced1b50c6f258f40fd71e/pkg/exec/schema/exec.json#L158-L165

It needs a patternProperty and a definition named invokeStep.

@vdice
Copy link
Member Author

vdice commented Aug 23, 2019

Thanks, @carolynvs !

Finally got around to updating this mixin's schema (including the use of patternProperty for the invokeStep, thank you for the reference) and adding tests. Please see 77cf95d

@vdice vdice force-pushed the feat/add-custom-action-support branch 2 times, most recently from a792ae6 to 9e6924b Compare August 23, 2019 21:54
@vdice vdice force-pushed the feat/add-custom-action-support branch from 9e6924b to db6220c Compare August 26, 2019 17:33
Copy link
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vdice vdice merged commit eb67925 into getporter:master Aug 26, 2019
@vdice vdice deleted the feat/add-custom-action-support branch August 26, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update schema, add tests
2 participants