Remove Widget dev console errors (#4177)

getredash · Sep 24, 2019 · 401d164 · 401d164
1 parent ff041b7
commit 401d164
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/client/app/components/dashboards/dashboard-widget/VisualizationWidget.jsx b/client/app/components/dashboards/dashboard-widget/VisualizationWidget.jsx
@@ -70,7 +70,8 @@ function RefreshIndicator({ refreshStartedAt }) {
   );
 }
 
-RefreshIndicator.propTypes = { refreshStartedAt: Moment.isRequired };
+RefreshIndicator.propTypes = { refreshStartedAt: Moment };
+RefreshIndicator.defaultProps = { refreshStartedAt: null };
 
 function VisualizationWidgetHeader({ widget, refreshStartedAt, parameters, onParametersUpdate }) {
   const canViewQuery = currentUser.hasPermission('view_query');
@@ -293,7 +294,7 @@ class VisualizationWidget extends React.Component {
             onExpand={this.expandWidget}
           />
         )}
-        data-refreshing={isRefreshing}
+        tileProps={{ 'data-refreshing': isRefreshing }}
       >
         {this.renderVisualization()}
       </Widget>

diff --git a/client/app/components/dashboards/dashboard-widget/Widget.jsx b/client/app/components/dashboards/dashboard-widget/Widget.jsx
@@ -70,6 +70,7 @@ class Widget extends React.Component {
     isPublic: PropTypes.bool,
     refreshStartedAt: Moment,
     menuOptions: PropTypes.node,
+    tileProps: PropTypes.object, // eslint-disable-line react/forbid-prop-types
     onDelete: PropTypes.func,
   };
 
@@ -82,6 +83,7 @@ class Widget extends React.Component {
     isPublic: false,
     refreshStartedAt: null,
     menuOptions: null,
+    tileProps: {},
     onDelete: () => {},
   };
 
@@ -105,12 +107,12 @@ class Widget extends React.Component {
   };
 
   render() {
-    const { widget, className, children, header, footer, canEdit, isPublic,
-      onDelete, menuOptions, ...otherProps } = this.props;
+    const { className, children, header, footer, canEdit, isPublic,
+      menuOptions, tileProps } = this.props;
     const showDropdownButton = !isPublic && (canEdit || !isEmpty(menuOptions));
     return (
       <div className="widget-wrapper">
-        <div className={cx('tile body-container', className)} {...otherProps}>
+        <div className={cx('tile body-container', className)} {...tileProps}>
           <div className="widget-actions">
             {showDropdownButton && (
               <WidgetDropdownButton