Prevent blank edit-in-place value (#3557)

getredash · Mar 11, 2019 · 93ec19b · 93ec19b
1 parent 63d3f22
commit 93ec19b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/client/app/components/EditInPlace.jsx b/client/app/components/EditInPlace.jsx
@@ -1,6 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { react2angular } from 'react2angular';
+import { trim } from 'lodash';
 
 export class EditInPlace extends React.Component {
   static propTypes = {
@@ -40,7 +41,7 @@ export class EditInPlace extends React.Component {
   };
 
   stopEditing = () => {
-    const newValue = this.inputRef.current.value;
+    const newValue = trim(this.inputRef.current.value);
     const ignorableBlank = this.props.ignoreBlanks && newValue === '';
     if (!ignorableBlank && newValue !== this.props.value) {
       this.props.onDone(newValue);