Added test ids for widget tests

getredash · Mar 14, 2019 · eaf1d8e · eaf1d8e
1 parent f48068f
commit eaf1d8e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 17 deletions.
diff --git a/client/app/components/QuerySelector.jsx b/client/app/components/QuerySelector.jsx
@@ -113,9 +113,10 @@ export function QuerySelector(props) {
         {searchResults.map(q => (
           <a
             href="javascript:void(0)"
-            className={cx('list-group-item', { inactive: q.is_draft })}
+            className={cx('query-selector-result', 'list-group-item', { inactive: q.is_draft })}
             key={q.id}
             onClick={() => selectQuery(q.id)}
+            data-test={`QueryId${q.id}`}
           >
             {q.name}
             {' '}

diff --git a/client/app/components/dashboards/AddWidgetDialog.jsx b/client/app/components/dashboards/AddWidgetDialog.jsx
@@ -144,21 +144,23 @@ class AddWidgetDialog extends React.Component {
         okText="Add to Dashboard"
         width={700}
       >
-        <QuerySelector onChange={query => this.selectQuery(query)} />
-        {this.state.selectedQuery && this.renderVisualizationInput()}
-
-        {
-          (this.state.parameterMappings.length > 0) && [
-            <label key="parameters-title" htmlFor="parameter-mappings">Parameters</label>,
-            <ParameterMappingListInput
-              key="parameters-list"
-              id="parameter-mappings"
-              mappings={this.state.parameterMappings}
-              existingParams={existingParams}
-              onChange={mappings => this.updateParamMappings(mappings)}
-            />,
-          ]
-        }
+        <div data-test="AddWidgetDialog">
+          <QuerySelector onChange={query => this.selectQuery(query)} />
+          {this.state.selectedQuery && this.renderVisualizationInput()}
+
+          {
+            (this.state.parameterMappings.length > 0) && [
+              <label key="parameters-title" htmlFor="parameter-mappings">Parameters</label>,
+              <ParameterMappingListInput
+                key="parameters-list"
+                id="parameter-mappings"
+                mappings={this.state.parameterMappings}
+                existingParams={existingParams}
+                onChange={mappings => this.updateParamMappings(mappings)}
+              />,
+            ]
+          }
+        </div>
       </Modal>
     );
   }

diff --git a/client/app/pages/dashboards/dashboard.html b/client/app/pages/dashboards/dashboard.html
@@ -97,7 +97,7 @@ <h3>
       <div class="dashboard-widget-wrapper"
         ng-repeat="widget in $ctrl.dashboard.widgets track by widget.id"
         gridstack-item="widget.options.position" gridstack-item-id="{{ widget.id }}">
-        <div class="grid-stack-item-content">
+        <div class="grid-stack-item-content" data-test="WidgetId{{ widget.id }}">
           <dashboard-widget widget="widget" dashboard="$ctrl.dashboard" on-delete="$ctrl.removeWidget(widget.id)"></dashboard-widget>
         </div>
       </div>